05Sheet 05.02 · Findings

Upstream bugs reproduced

Six real bugs in wallet-backend and the SDKs, reproduced: wallet-backend from corpus ledgers, the SDKs from conformance test vectors. Each fails on the build before its fix and passes after.

Verdicts come from state, never from log text: the ingest cursor and the stored bytes for replay, the value returned for conformance.

In an indexer: wallet-backend

Run by make replay: real wallet-backend builds read corpus ledgers through a mock stellar-rpc. See Replay.

ReferenceCorpusBuildExpected verdict
wallet-backend#716Signed-payload signer, testnet 4437356–443735979ea2acd (#715)Stores the signer as 33 bytes: payload lost
wallet-backend#729the same ledgers6e5a5910 (#693)Halts at 4437357
2c873353 (#729, the fix)Stores the full 41-byte key
wallet-backend#731SAC trustline, P28 variant764a4f5bDrops the trustline: no TRUSTLINE/ADD
c152783c (#734, the fix)Records it

In the SDKs

Run by make conformance: the same vectors through several builds of each SDK. See Conformance.

ReferenceWhat breaksFails onPasses on
js-stellar-sdk#1766Assets ordered by strkey text instead of XDR bytesjs 17.2.0, and its twin on go-stellar-sdk v0.7.1js 17.2.1, go v0.7.2
js-stellar-sdk#1785Muxed IDs and offer IDs accepted in non-canonical formsjs 17.2.0, 17.2.1js 17.3.0
js-stellar-sdk#1789Map keys that collide on native conversion, silently droppedjs 17.2.0, 17.2.1js 17.3.0

On this page